[ipcdn] Review of draft-ietf-ipcdn-pktc-mtamib-04.txt
"Dave Thaler" <dthaler@windows.microsoft.com> Thu, 05 August 2004 19:13 UTC
Received: from ietf-mx.ietf.org (ietf-mx.ietf.org [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id PAA08142 for <ipcdn-archive@ietf.org>; Thu, 5 Aug 2004 15:13:01 -0400 (EDT)
Received: from megatron.ietf.org ([132.151.6.71]) by ietf-mx.ietf.org with esmtp (Exim 4.33) id 1BsnjH-000376-VK for ipcdn-archive@ietf.org; Thu, 05 Aug 2004 15:16:44 -0400
Received: from localhost.localdomain ([127.0.0.1] helo=megatron.ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1Bsnbs-0001N2-W2; Thu, 05 Aug 2004 15:09:04 -0400
Received: from odin.ietf.org ([132.151.1.176] helo=ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1Bsbp5-0000RO-I2 for ipcdn@megatron.ietf.org; Thu, 05 Aug 2004 02:33:55 -0400
Received: from ietf-mx.ietf.org (ietf-mx.ietf.org [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id CAA27335 for <ipcdn@ietf.org>; Thu, 5 Aug 2004 02:33:54 -0400 (EDT)
Received: from mail3.microsoft.com ([131.107.3.123]) by ietf-mx.ietf.org with esmtp (Exim 4.33) id 1BsbsV-0000ka-LF for ipcdn@ietf.org; Thu, 05 Aug 2004 02:37:29 -0400
Received: from mailout2.microsoft.com ([157.54.1.120]) by mail3.microsoft.com with Microsoft SMTPSVC(6.0.3790.196); Wed, 4 Aug 2004 23:35:27 -0700
Received: from red-imc-02.redmond.corp.microsoft.com ([157.54.9.107]) by mailout2.microsoft.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 4 Aug 2004 23:33:19 -0700
Received: from win-imc-02.wingroup.windeploy.ntdev.microsoft.com ([157.54.0.84]) by red-imc-02.redmond.corp.microsoft.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 4 Aug 2004 23:33:18 -0700
Received: from WIN-MSG-10.wingroup.windeploy.ntdev.microsoft.com ([157.54.12.81]) by win-imc-02.wingroup.windeploy.ntdev.microsoft.com with Microsoft SMTPSVC(6.0.3790.1069); Wed, 4 Aug 2004 23:32:40 -0700
x-mimeole: Produced By Microsoft Exchange V6.5.7226.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 04 Aug 2004 23:33:12 -0700
Message-ID: <C9588551DE135A41AA2626CB645309370A7E0060@WIN-MSG-10.wingroup.windeploy.ntdev.microsoft.com>
Thread-Topic: Review of draft-ietf-ipcdn-pktc-mtamib-04.txt
thread-index: AcR6thTZfq+7VKivT3+3uhPKgFAc5A==
From: Dave Thaler <dthaler@windows.microsoft.com>
To: enechamkin@broadcom.com, jf.mule@cablelabs.com
X-OriginalArrivalTime: 05 Aug 2004 06:32:40.0978 (UTC) FILETIME=[0205AF20:01C47AB6]
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 21bf7a2f1643ae0bf20c1e010766eb78
Content-Transfer-Encoding: quoted-printable
X-Mailman-Approved-At: Thu, 05 Aug 2004 15:09:03 -0400
Cc: randy_presuhn@mindspring.com, "Wijnen, Bert (Bert)" <bwijnen@lucent.com>, ipcdn@ietf.org, "C. M. Heard" <heard@pobox.com>
Subject: [ipcdn] Review of draft-ietf-ipcdn-pktc-mtamib-04.txt
X-BeenThere: ipcdn@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IP over Cable Data Network <ipcdn.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/ipcdn>, <mailto:ipcdn-request@ietf.org?subject=unsubscribe>
List-Post: <mailto:ipcdn@ietf.org>
List-Help: <mailto:ipcdn-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/ipcdn>, <mailto:ipcdn-request@ietf.org?subject=subscribe>
Sender: ipcdn-bounces@ietf.org
Errors-To: ipcdn-bounces@ietf.org
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 3d7f2f6612d734db849efa86ea692407
Content-Transfer-Encoding: quoted-printable
Here's my MIB Doctor review of this document and what I believe MUST/SHOULD/MAY be fixed. MUST fix -------- 1) There is no IANA Considerations section, and this is now required in the new guidelines. The draft needs something like (based on the template in the guidelines): 9. IANA Considerations The MIB module in this document uses the following IANA-assigned OBJECT IDENTIFIER values recorded in the SMI Numbers registry: Descriptor OBJECT IDENTIFIER value ---------- ----------------------- pktcMtaMib { mib-2 XXX } Editor's Note (to be removed prior to publication): the IANA is requested to assign a value for "XXX" under the 'mib-2' subtree and to record the assignment in the SMI Numbers registry. When the assignment has been made, the RFC Editor is asked to replace "XXX" (here and in the MIB module) with the assigned value and to remove this note. 2) The page header on pages 2-51 says July 2002 3) MIB Guidelines say If the module was developed by an IETF working group, then the ORGANIZATION clause MUST provide the full name of the working group ^^^^^^^^^ The draft just uses the WG acronym: ORGANIZATION "IETF IPCDN Working Group " 4) The LAST-UPDATED date predates the REVISION date: LAST-UPDATED "200406160000Z" -- June 16, 2004 REVISION "200407160000Z" ^ 5) pktcMtaBasicSmtaCompliance contains MODULE DOCS-CABLE-DEVICE-MIB MANDATORY-GROUPS { docsDevSoftwareGroupV2 } but RFC2669 is not referenced as a normative reference and docsDevSoftwareGroupV2 isn't in there anyway, only docsDevSoftwareGroup. Is this blocked on the progression of another document containing this? Looks like this used to be in draft-ietf-ipcdn-device-mibv2-*.txt which has now expired. 6) SEQUENCE element #4 `pktcMtaDevCmsSolicitedKeyTimeout' does not match order of columnar objects under `pktcMtaDevCmsEntry'. Should swap the following two lines: pktcMtaDevCmsSolicitedKeyTimeout Unsigned32, pktcMtaDevCmsMaxClockSkew Unsigned32, 7) pktcMtaDevProvisioningState has 'passWithWarning' (singular) in the enum, but 'passWithWarnings' (plural) twice in the DESCRIPTION. Also has 'failOtherReason' in the enum but 'failureOtherReason' in the DESCRIPTION. 8) The comment on page 29 refers to draft-ietf-ipcdn-pktc-signaling-02.txt This should be added to the references section of the doc. Also grammar error "Upper case must be use to" ^^^ 9) Typo in DESCRIPTION of pktcMtaDevCmsKerbRealmName: realm table (pktcMtaDevRealmtable)." ^ capitalize 10) The DESCRIPTION of pktcMtaDevRealmTgsGracePeriod has weird indentation, and includes weird characters (as do several other objects). SHOULD fix ---------- 11) pktcMtaDevErrorOidIndex: say what happens after the value 1024 is reached 12) pktcMtaDevErrorOid, pktcMtaDevErrorValue, etc: why are OIDs of type SnmpAdminString rather than an OBJECT IDENTIFIER type/subtype? As is, the management station cannot do simple things like expanding the OID into the defined string tokens in the MIB. 13) pktcMtaDevServerDhcp1, pktcMtaDevServerDns1, etc: the DESCRIPTION of these objects is worded as if the type is a string rather than an InetAddress (the "dotted" IP address, etc). Technically, there's no dots in the value, only in the displayed version of it. 14) pktcMtaDevServerAddressType: what does it mean for this to be read-write but the dependent InetAddress fields to be read-only? I.e., what happens to the latter immediately after the former is set? MAY fix ------- 15) Consider defining a TC for kerberos realm names, since this is used by multiple objects (pktcMtaDevProvKerbRealmName, pktcMtaDevRealmName, and pktcMtaDevCmsKerbRealmName) and has special syntax restrictions (1..255 upper case ASCII chars) 16) The current conformance statements require read-write in implementations to be compliant. Is this intended? Since it currently only supports ipv4, it doesn't seem useful to require read-write access to the InetAddressType objects. 17) pktcMtaDevSwCurrentVers is redundant with sysDescr, so why is this needed? The draft says: The data presented in this object MUST be identical to the software version information contained in the 'sysDescr' MIB object of the MTA. 18) The MIB guidelines suggest using { pktcMtaMib 0 } for the notification prefix. The draft currently requires two definitions: pktcMtaNotificationPrefix OBJECT IDENTIFIER ::= { pktcMtaMib 2 } pktcMtaNotification OBJECT IDENTIFIER ::= { pktcMtaNotificationPrefix 0 } Is there a good reason for this? (e.g. already deployed implementations?) 19) What is the expected behavior when reading pktcMtaDevRealmName and pktcMtaDevRealmOrgName when the row is first created and they are not set? (There's no DEFVAL, and the MIB doesn't say they have to be set in the initial createAndWait set.) 20) draft-ietf-ipcdn-bpiplus-mib-12.txt is referenced, and is now draft-ietf-ipcdn-bpiplus-mib-13.txt 21) The wording in section 8 varies marginally from the template. Template: > Some of the readable objects in this MIB module (i.e., objects with a > MAX-ACCESS other than not-accessible) may be considered sensitive or Actual: > Some of the readable objects in this MIB module may be considered > sensitive or [...] _______________________________________________ IPCDN mailing list IPCDN@ietf.org https://www1.ietf.org/mailman/listinfo/ipcdn
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Wijnen, Bert (Bert)
- [ipcdn] Review of draft-ietf-ipcdn-pktc-mtamib-04… Dave Thaler
- [ipcdn] snmp version-specific behavior in draft-i… Randy Presuhn
- RE: [ipcdn] Review of draft-ietf-ipcdn-pktc-mtami… Jean-Francois Mule
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Jean-Francois Mule
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Jean-Francois Mule
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Eugene Nechamkin
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Wijnen, Bert (Bert)
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Dave Thaler
- [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-mtami… Dave Thaler
- RE: [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-m… Jean-Francois Mule
- RE: [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-m… Dave Thaler
- RE: [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-m… Jean-Francois Mule
- RE: [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-m… Jean-Francois Mule
- RE: [ipcdn] RE: Review of draft-ietf-ipcdn-pktc-m… Wijnen, Bert (Bert)